build: do not merge interface members with class API members #18088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
Currently we always merge _all_ members defined by interfaces into the members of Dgeni class API documents. This causes optional interface members to show up even if they are not implemented. To fix this, the member merging processor has been reworked to not even ever consider interfaces for the API docs. Instead, only members which are "extended" should show up. Support for mixins using intersection types has been added. Fixes angular#17148. Fixes angular#18014.
devversion
changed the title
devversion
force-pushed
the
build/docs-do-not-show-interfaces
branch
from
e1c2b8b to
5c32105
Compare
|
Note: This logic could also be useful in the future if we combine our API docs logic with the one from |
jelbourn
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…#18088) Currently we always merge _all_ members defined by interfaces into the members of Dgeni class API documents. This causes optional interface members to show up even if they are not implemented. To fix this, the member merging processor has been reworked to not even ever consider interfaces for the API docs. Instead, only members which are "extended" should show up. Support for mixins using intersection types has been added. Fixes angular#17148. Fixes angular#18014.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always merge all members defined by interfaces
into the members of Dgeni class API documents. This causes optional
interface members to show up even if they are not implemented.
To fix this, the member merging processor has been reworked to
not even ever consider interfaces for the API docs and to handle mixins
defined through intersection types. Only members which are actually
defined/inherited should show up in the API docs.
Merging properties of interfaces was done in the past to handle mixins, but
this is no longer needed and its generally wrong to merge properties from interfaces..
Fixes #17148. Fixes #18014.