Skip to content

refactor: fix typescript 3.7 compilation errors. #18141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

refactor: fix typescript 3.7 compilation errors. #18141

merged 1 commit into from
Jan 13, 2020

Conversation

andrius-pra
Copy link
Contributor

Fixes Import declaration conflicts with local declaration error.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 9, 2020
@jelbourn jelbourn added the target: major This PR is targeted for the next major release label Jan 9, 2020
@jelbourn jelbourn added this to the 9.0.0 milestone Jan 9, 2020
jelbourn
jelbourn approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 9, 2020
@jelbourn
Copy link
Member

jelbourn commented Jan 9, 2020

Caretaker: cherrypick this into the 9.0.x branch

@jelbourn jelbourn added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed and removed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jan 9, 2020
@devversion
Copy link
Member

Actually, the FloatLabelType should not be deleted, and the import should be removed.

@devversion devversion assigned devversion and unassigned devversion Jan 9, 2020
@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Jan 9, 2020
@devversion
Copy link
Member

Thanks for updating @andrius-pra. Looks like this unveiled another issue. Can you update src/dev-app/mdc-input/mdc-input-demo.ts#L11 to not import FloatLabelType from core, but from the mdc-form-field import? I think/hope that this should make CI green.

@andrius-pra
refactor: fix typescript 3.7 compilation errors.Fixes `Import declara…
6c2c9d4 
…tion conflicts with local declaration` error.
@andrius-pra
Copy link
Contributor Author

Done

devversion
devversion approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@devversion devversion added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround labels Jan 13, 2020
@devversion
Copy link
Member

Marking as P2 to unblock the TypeScript 3.7 update PR on framework.

@andrius-pra andrius-pra mentioned this pull request Jan 13, 2020
Closed
Splaktar
Splaktar approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Jan 13, 2020
@jelbourn jelbourn merged commit 7cced9c into angular:master Jan 13, 2020
jelbourn pushed a commit that referenced this pull request Jan 13, 2020
@andrius-pra @jelbourn
refactor: fix typescript 3.7 compilation errors.Fixes `Import declara…
b2da537 
…tion conflicts with local declaration` error. (#18141)

(cherry picked from commit 7cced9c)
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@andrius-pra @yifange
refactor: fix typescript 3.7 compilation errors.Fixes `Import declara…
9371eda 
…tion conflicts with local declaration` error. (angular#18141)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@Splaktar Splaktar Splaktar approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@andrius-pra @jelbourn @devversion @Splaktar @googlebot @mmalerba