fix(material/form-field): undeprecated legacy and standard appearances #18144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few bugs to address with outline and fill styles before we can deprecate these.
mmalerba
added
P1
googlebot
added
the
cla: yes
|
Reverts PR #17961. |
devversion
approved these changes
Jan 12, 2020
There was a problem hiding this comment.
I think we should write down what the plan for the MDC version is. Surely, it will be on the list to ensure that the alignment issues are solved, but since this will shift the deprecation, the MDC form-field either needs to wait until we can make this breaking change, or we need to provide a standard/legacy implementation?
devversion
added
pr: lgtm
action: merge
mmalerba
added
the
merge: caretaker note
|
CARETAKER NOTE: cherrypick into 9.0.x branch |
andrewseguin
pushed a commit
that referenced
this pull request
Jan 15, 2020
#18144) There are a few bugs to address with outline and fill styles before we can deprecate these.
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
angular#18144) There are a few bugs to address with outline and fill styles before we can deprecate these.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few bugs to address with outline and fill styles before we
can deprecate these.