refactor: vendor used typescript ast utils from @schematics/angular #18155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly accessing utility functions from `@schematics/angular`, we should vendor the AST utils we need. This is necessary because `@schematics/angular` vendors TypeScript, and this causes a type mismatch if we try to pass in `ts.Node`'s which are created from the TypeScript version available to `@angular/cdk/schematics`. Using the vendored TS version from `@schematics/angular` is not an option as it complicates our setup, gives us less control, and will be hard to consistently enforce in the schematic code. We tried to do this with the `version agnostic typescript` code, but it had downsides in terms of type safety and convenience.
devversion
added
P2
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…ar (angular#18155) Instead of directly accessing utility functions from `@schematics/angular`, we should vendor the AST utils we need. This is necessary because `@schematics/angular` vendors TypeScript, and this causes a type mismatch if we try to pass in `ts.Node`'s which are created from the TypeScript version available to `@angular/cdk/schematics`. Using the vendored TS version from `@schematics/angular` is not an option as it complicates our setup, gives us less control, and will be hard to consistently enforce in the schematic code. We tried to do this with the `version agnostic typescript` code, but it had downsides in terms of type safety and convenience.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of directly accessing utility functions from
@schematics/angular, we shouldvendor the AST utils we need. This is necessary because
@schematics/angularvendorsTypeScript, and this causes a type mismatch if we try to pass in
ts.Node's which arecreated from the TypeScript version available to
@angular/cdk/schematics.Using the vendored TS version from
@schematics/angularis not anoption as it complicates our setup, gives us less control, and will
be hard to consistently enforce in the schematic code. We tried
to do this with the
version agnostic typescriptcode, but ithad downsides in terms of type safety and convenience.
Note: Marked as P2 as it is needed to unblock angular/angular#33717