Skip to content

build: make cross entrypoint rule an AbstractRule #18156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

build: make cross entrypoint rule an AbstractRule #18156

merged 1 commit into from
Jan 15, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 12, 2020 •
edited
Loading

Currently the cross entrypoint import rule is a TypedRule which means that it might use the type checker and it won't work in vscode. Since it doesn't actually use the type checker, these changes turn it into an AbstractRule.

@crisbeto
build: make cross entrypoint rule an AbstractRule
4d29a6a 
Currently the cross entrypoint import rule us a `TypedRule` which means that it might use the type checker and it won't work in vscode. Since it doesn't actually use the type checker, these changes turn it into an `AbstractRule`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 12, 2020
@crisbeto crisbeto requested a review from a team as a code owner January 12, 2020 10:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 12, 2020
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 12, 2020
jelbourn
jelbourn approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Off-topic: I always find seeing lint rules in my IDE to be more annoying than helpful because they always show up while I'm in the middle of writing. It's like, "Yeah, I know it's an unused variable, I just made it, give me a minute".

@andrewseguin andrewseguin merged commit 1d9033e into angular:master Jan 15, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
build: make cross entrypoint rule an AbstractRule (angular#18156)
02187c3 
Currently the cross entrypoint import rule us a `TypedRule` which means that it might use the type checker and it won't work in vscode. Since it doesn't actually use the type checker, these changes turn it into an `AbstractRule`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @googlebot @andrewseguin