docs: grammar test-harness #18293
docs: grammar test-harness #18293
Conversation
googlebot
added
the
cla: yes
src/cdk/testing/test-harnesses.md
Outdated
| There are times when a component harness might need to access elements outside of it's corresponding | ||
| component's host element. A good example of this is components that use the | ||
| There are times when a component harness might need to access elements outside of its corresponding | ||
| component's host element. A good example of this are the components that use the |
There was a problem hiding this comment.
This still sounds a bit awkward because "A good example" is singular and "the components" is plural. Maybe change the beginning of the sentence to "Some good examples of this are"
There was a problem hiding this comment.
This does indeed read better, I changed it.
mmalerba
added
pr: lgtm
action: merge
src/cdk/testing/test-harnesses.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| `@angular/cdk/testing` provides infrastructure to help with testing Angular components. | |||
| `@angular/cdk/testing` provides an infrastructure to help with testing Angular components. | |||
There was a problem hiding this comment.
I think this read better without the "an"
src/cdk/testing/test-harnesses.md
Outdated
| @@ -385,7 +385,7 @@ authors to write easily understandable code, e.g. | |||
| for the particular subclass. | |||
|
|
|||
| Harnesses that need to add additional options should extend the `BaseHarnessFilters` interface and | |||
| additional optional properties as needed. `HarnessPredicate` provides several convenience methods | |||
| additional optional properties as needed. `HarnessPredicate` provides several convenient methods | |||
There was a problem hiding this comment.
"Convenience method" is actually a generally well-known concept: https://en.wiktionary.org/wiki/convenience_method
There was a problem hiding this comment.
Thanks for the review, I addressed the feedback
src/cdk/testing/test-harnesses.md
Outdated
| There are times when a component harness might need to access elements outside of it's corresponding | ||
| component's host element. A good example of this is components that use the | ||
| There are times when a component harness might need to access elements outside of its corresponding | ||
| component's host element. Some good examples of this are the components that use the |
There was a problem hiding this comment.
I would do
"Components that use CDK overlay serve as examples of this"
Avoids passive voice
(cherry picked from commit dfb3e05)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.