build: enable all ngtsc strictness flags #18339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Jan 30, 2020
crisbeto
force-pushed
the
enable-all-strictness
branch
6 times, most recently
from
ca79faf to
ed81d54
Compare
crisbeto
added
P3
devversion
approved these changes
Jan 30, 2020
devversion
reviewed
Jan 30, 2020
Re-enables the `strictDomLocalRefTypes` and `strictDomEventTypes`, fixes a few legitimate failures and works around the rest.
crisbeto
force-pushed
the
enable-all-strictness
branch
from
ed81d54 to
44568bd
Compare
crisbeto
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Jan 30, 2020
Re-enables the `strictDomLocalRefTypes` and `strictDomEventTypes`, fixes a few legitimate failures and works around the rest. (cherry picked from commit 2c4e2af)
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Feb 6, 2020
Re-enables the `strictDomLocalRefTypes` and `strictDomEventTypes`, fixes a few legitimate failures and works around the rest.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables the
strictDomLocalRefTypesandstrictDomEventTypes, fixes a few legitimate failures and works around the rest.