-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(checkbox): not handling unknown color palette #18467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0410756
to
ca251a7
Compare
Any hope to get this merged? Just spent hours trying to figure out if the issue was my custom styles and then stumbled upon this... |
Bumping to P2 because changing the default click action without setting the color leads to a broken checkbox |
@crisbeto this has a very subtle breakage. If someone uses the provider to set the default color to primary and also has a |
I never considered that @jelbourn, but it sounds like this is broken inside the |
This is something that came up in angular#18467. Currently the default values in the `mixinColor` and `mixinTabIndex` are set when the mixin class is created, however we have some components where the default color can be configured through an injection token. These changes add a default field on each instance so that it can be updated after the class is instantiated.
This is something that came up in angular#18467. Currently the default values in the `mixinColor` and `mixinTabIndex` are set when the mixin class is created, however we have some components where the default color can be configured through an injection token. These changes add a default field on each instance so that it can be updated after the class is instantiated.
Blocked on #20125. |
One more change will be needed - the MDC checkbox doesn't have a Either a |
#20125) This is something that came up in #18467. Currently the default values in the `mixinColor` and `mixinTabIndex` are set when the mixin class is created, however we have some components where the default color can be configured through an injection token. These changes add a default field on each instance so that it can be updated after the class is instantiated.
Fixes the checkbox component not falling back to the default color, if the color is `undefined`. We need to handle this, because `ThemePalette` allows `undefined`. Fixes angular#18465.
ca251a7
to
aa9ceeb
Compare
Updated to add the same behavior to the MDC checkbox. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the checkbox component not falling back to the default color, if the color is
undefined
. We need to handle this, becauseThemePalette
allowsundefined
.Fixes #18465.