fix(ng-update): do not throw if project does not have dependencies #18470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v9 hammerjs migration in some cases tries to remove `hammerjs` from the workspace `package.json`. It always assumes that there is a `dependencies` property. This is not always guaranteed because a project doesn't need to define this property. This change guards against this case and avoids a runtime migration exception. Fixes angular#18469.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
|
Note: I did not add a unit test for this change (had one initially) because it's an edge-case that a CLI project does not have any |
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2020
…18470) The v9 hammerjs migration in some cases tries to remove `hammerjs` from the workspace `package.json`. It always assumes that there is a `dependencies` property. This is not always guaranteed because a project doesn't need to define this property. This change guards against this case and avoids a runtime migration exception. Fixes #18469. (cherry picked from commit 01e4fba)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v9 hammerjs migration in some cases tries to remove
hammerjsfrom the workspace
package.json. It always assumes that there isa
dependenciesproperty. This is not always guaranteed because aproject doesn't need to define this property. This change guards against
this case and avoids a runtime migration exception.
Fixes #18469.