fix(material-experimental/mdc-form-field): setup typography styles for form-fields #18480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
mmalerba
approved these changes
Feb 12, 2020
mmalerba
added
pr: lgtm
action: merge
This comment has been minimized.
This comment has been minimized.
…r form-fields Currently the MDC-based form-field does not have any typography styles. MDC only sets typography styles on the inputs and textarea elements. This won't work for our form-field since we support custom form-field controls. To make this work, the input/textarea elements inherit the font styles from parent elements, but we need to set up the typography styles for the containing `mat-form-field` element.
devversion
force-pushed
the
fix/mdc-form-field-proper-input-styles
branch
from
18eace0 to
fd99c5c
Compare
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MDC-based form-field does not have any typography styles.
MDC only sets typography styles on the inputs and textarea elements.
This won't work for our form-field since we support custom form-field
controls. To make this work, the input/textarea elements inherit the
font styles from parent elements, but we need to set up the typography
styles for the containing
mat-form-fieldelement.