build: temporarily disable safari 10 browserstack tests #18483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
build/temporarily-disable-safari-10
branch
from
270548b to
c1f645c
Compare
|
Pushed again. This time just disabling the |
|
@devversion do you need to remove it from some required list of checks? now the status is yellow-dot |
|
@mmalerba Good point. Updated. I wish it would have been only a temporary change at a single place. |
mmalerba
pushed a commit
that referenced
this pull request
Feb 19, 2020
* build: temporarily disable safari 10 browserstack tests * Update angular-robot.yml * Update angular-robot.yml
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling Safari 10 BrowserStack test temporarily since they started failing magically.
The server complains about a missing
devicecapability. This doesn't make sense since we are not testing mobile devices where adevicename needs to be specified.