Skip to content

chore: remove unused webdriver-manager yarn script alias #18550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Feb 19, 2020

The webdriver-manager is no longer needed now that we run e2e tests with Bazel.
The script we added for it in the package.json can be removed.

The webdriver-manager is no longer needed now that we run
e2e tests with Bazel. The script we added for it in the
`package.json` can be removed.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 19, 2020
@devversion devversion requested review from jelbourn and a team as code owners February 19, 2020 14:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 19, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 19, 2020
@jelbourn jelbourn merged commit fdae14a into angular:master Feb 19, 2020
jelbourn pushed a commit that referenced this pull request Feb 19, 2020
The webdriver-manager is no longer needed now that we run
e2e tests with Bazel. The script we added for it in the
`package.json` can be removed.

(cherry picked from commit fdae14a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants