-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(toolbar): spruce up the toolbar component examples #18745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looking to get initial feedback on this. Is this the sort of thing you're looking for to spruce examples up? Should there be more styling or complex interactions? I wasn't sure since the demo pages seem to start with "Basic usage" on the overview page and keep the fancier examples in the demo section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a step in the right direction! I would continue to expand the overview here with some additional examples that showcase a few more features. I think the end result would be something like
toolbar-overview-example
- what you have now, plus an example of changing the color, and an example with two rows.toolbar-basic-example
- what you have now by itselftoolbar-multirow-example
- no changes from what's there
The goal is to make it more immediately clear what the component can do the very first time someone lands on the overview, while still have more discrete examples for specific use-cases.
One other thing I would add to this PR: add your examples to the toolbar demo page in the dev-app. That will make it easy for someone on the team to pull down your change and test it out. Here's an example of what I mean: 20b7c77
It would also be great if you could paste a screenshot of the example in the PR description (GitHub lets you paste images directly into the description)
src/components-examples/material/toolbar/toolbar-overview/toolbar-overview-example.html
Outdated
Show resolved
Hide resolved
Awesome, thanks for the feedback! I've added a couple more examples to toolbar-overview-example and then added it to the toolbar demo page in dev-app. |
@jelbourn Is there anything else I should add to this PR or change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small nit
(sorry for the delayed review, this accidentally fell off my radar)
src/components-examples/material/toolbar/toolbar-overview/toolbar-overview-example.ts
Outdated
Show resolved
Hide resolved
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Screenshot of basic, colored, and multi-row toolbars included in toolbar-overview-example:
