Skip to content

fix(drag-drop): handle custom preview/placeholder with multiple root nodes #18829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix(drag-drop): handle custom preview/placeholder with multiple root nodes #18829

merged 1 commit into from
Mar 31, 2020

Conversation

crisbeto
Copy link
Member

We support passing in a custom preview or placeholder using an ng-template, but we were only taking the first rootNode from the template.

@crisbeto
fix(drag-drop): handle custom preview/placeholder with multiple root …
a50e875 
…nodes

We support passing in a custom preview or placeholder using an `ng-template`, but we were only taking the first `rootNode` from the template.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 14, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2020
jelbourn
jelbourn approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 30, 2020
@jelbourn jelbourn merged commit 8a71288 into angular:master Mar 31, 2020
jelbourn pushed a commit that referenced this pull request Apr 6, 2020
@crisbeto @jelbourn
fix(drag-drop): handle custom preview/placeholder with multiple root …
92aed70 
…nodes (#18829)

We support passing in a custom preview or placeholder using an `ng-template`, but we were only taking the first `rootNode` from the template.

(cherry picked from commit 8a71288)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot