Skip to content

build: update to rules_nodejs 1.5.0 #18960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2020
Merged

build: update to rules_nodejs 1.5.0 #18960

merged 3 commits into from
Apr 3, 2020

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Mar 31, 2020 •
edited
Loading

Also patches @angular/bazel as a pre-req to landing angular/angular#36333.

@gregmagolan gregmagolan requested review from jelbourn and a team as code owners March 31, 2020 21:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 31, 2020
@gregmagolan gregmagolan force-pushed the rules_nodejs_1.5.0 branch 2 times, most recently from 96af29a to 7d45613 Compare March 31, 2020 21:30
josephperrott
josephperrott requested changes Apr 1, 2020
View reviewed changes
@devversion devversion added lgtm target: patch This PR is targeted for the next patch release labels Apr 1, 2020
@gregmagolan
Copy link
Contributor Author

Adding missing *yarn_install to integration_test CI job here after discussing offline with @devversion . node_modules cache is invalidated here which surfaced the missing step.

josephperrott
josephperrott approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 1, 2020
@gregmagolan gregmagolan mentioned this pull request Apr 2, 2020
Closed
14 tasks
@jelbourn jelbourn merged commit e4cfa2b into angular:master Apr 3, 2020
@devversion devversion added the P2 The issue is important to a large percentage of users, with a workaround label Apr 3, 2020
jelbourn pushed a commit that referenced this pull request Apr 6, 2020
@gregmagolan @jelbourn
build: update to rules_nodejs 1.5.0 (#18960)
871c3cf 
* updates to rules_nodejs 1.5.0
* adds temporary patch to @angular/tools-bazel
* adds missing yarn_install to integration_test CI job

(cherry picked from commit e4cfa2b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gregmagolan @devversion @josephperrott @jelbourn @googlebot