Skip to content

build: sanitize postinstall patch markers #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

devversion
Copy link
Member

Yarn throws if patch markers with special characters are found
in restored node_modules. To fix this, patch markers are now
sanitized to not contain special characters.

Yarn throws if patch markers with special characters are found
in restored `node_modules`. To fix this, patch markers are now
sanitized to not contain special characters.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Apr 3, 2020
@devversion devversion requested a review from a team as a code owner April 3, 2020 19:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 3, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we file a bug with yarn?

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 3, 2020
@jelbourn jelbourn merged commit e0b5797 into angular:master Apr 3, 2020
@devversion
Copy link
Member Author

@jelbourn Yep. Created an issue upstream: yarnpkg/yarn#8044.

mmalerba pushed a commit that referenced this pull request Apr 14, 2020
Yarn throws if patch markers with special characters are found
in restored `node_modules`. To fix this, patch markers are now
sanitized to not contain special characters.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants