Skip to content

build: add MDC components to SSR kitchen sink #19013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

build: add MDC components to SSR kitchen sink #19013

merged 1 commit into from
Apr 8, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 7, 2020

Adds the radio button and card components to the kitchen sink so we can catch server-side rendering errors.

@crisbeto
build: add MDC components to SSR kitchen sink
2f3fde9 
Adds the radio button and card components to the kitchen sink so we can catch server-side rendering errors.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Apr 7, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner April 7, 2020 16:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 7, 2020
mmalerba
mmalerba approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 7, 2020
@mmalerba mmalerba merged commit d6564cc into angular:master Apr 8, 2020
mmalerba pushed a commit that referenced this pull request Apr 14, 2020
@crisbeto @mmalerba
build: add MDC components to SSR kitchen sink (#19013)
0cace8e 
Adds the radio button and card components to the kitchen sink so we can catch server-side rendering errors.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @googlebot