fix(material-experimental/mdc-radio): strong focus indicator not working #19091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: patch
googlebot
added
the
cla: yes
We recently added strong focus indication for the MDC-based radio, but accidentally used the strong-focus indication class from `@angular/material`. This means that strong focus indiciation won't work if only the focus indicator styles from `mdc-helpers` are used. This came up in the audit of classes for the MDC migration.
devversion
force-pushed
the
fix/focus-indicator-strong-mdc
branch
from
3d8e8ec to
652b826
Compare
jelbourn
pushed a commit
that referenced
this pull request
Apr 20, 2020
…ing (#19091) We recently added strong focus indication for the MDC-based radio, but accidentally used the strong-focus indication class from `@angular/material`. This means that strong focus indiciation won't work if only the focus indicator styles from `mdc-helpers` are used. This came up in the audit of classes for the MDC migration. (cherry picked from commit 3c99efc)
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…ing (angular#19091) We recently added strong focus indication for the MDC-based radio, but accidentally used the strong-focus indication class from `@angular/material`. This means that strong focus indiciation won't work if only the focus indicator styles from `mdc-helpers` are used. This came up in the audit of classes for the MDC migration.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added strong focus indication for the MDC-based radio, but
accidentally used the strong-focus indication class from
@angular/material.This means that strong focus indiciation won't work if only the
focus indicator styles from
mdc-helpersare used. This came upin the audit of classes for the MDC migration.