fix(material/radio): incorrect text color when placed inside an overlay with a dark theme #19113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Apr 20, 2020
crisbeto
changed the title
…ay with a dark theme Fixes a similar issue to angular#18742. The radio button inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.
crisbeto
force-pushed
the
radio-dark-theme-text-color
branch
from
25a6c9b to
47936ec
Compare
andrewseguin
removed
the
cla: yes
|
Closing this, because similar fixes for the checkbox and slide toggle ended up being reverted, because they were problematic internally. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a similar issue to #18742. The radio button inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.