Skip to content

fix(ng-add): ng add @angular/material fails in library projects #19164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020

Conversation

trik
Copy link
Contributor

@trik trik commented Apr 24, 2020

Skip app related ng-add steps when working with library projects

close #19156

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 24, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+💯 Thanks for fixing this.

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 24, 2020
@trik trik force-pushed the ng-add-library branch 2 times, most recently from 8ea00d9 to d15216b Compare April 27, 2020 07:40
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jelbourn should have a look too.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe labels May 6, 2020
@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label May 6, 2020
@trik trik force-pushed the ng-add-library branch from d15216b to cac94eb Compare May 14, 2020 16:25
@trik trik force-pushed the ng-add-library branch 3 times, most recently from 8921d29 to e5411a5 Compare May 15, 2020 08:15
Skip app related ng-add steps when working with library projects and warn about missing setup steps
@trik trik force-pushed the ng-add-library branch from e5411a5 to 350e893 Compare May 15, 2020 08:25
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label May 15, 2020
@jelbourn jelbourn merged commit 822e3e0 into angular:master May 21, 2020
jelbourn pushed a commit that referenced this pull request May 21, 2020
Skip app related ng-add steps when working with library projects and warn about missing setup steps
@trik trik deleted the ng-add-library branch May 21, 2020 06:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Material to a Library Project (Could not find the project main file inside of the workspace config)
5 participants