Skip to content

build: update to rules_nodejs 1.6.0 #19185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

build: update to rules_nodejs 1.6.0 #19185

merged 1 commit into from
Apr 30, 2020

Conversation

trik
Copy link
Contributor

@trik trik commented Apr 27, 2020

No description provided.

@trik trik requested review from jelbourn and a team as code owners April 27, 2020 17:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 27, 2020
@trik trik force-pushed the rules-nodejs-1.6.0 branch from b2c99f3 to 85cc254 Compare April 28, 2020 08:25
devversion
devversion reviewed Apr 28, 2020
View reviewed changes
josephperrott
josephperrott requested changes Apr 28, 2020
View reviewed changes
@josephperrott josephperrott self-requested a review April 28, 2020 14:21
@trik trik force-pushed the rules-nodejs-1.6.0 branch from 85cc254 to c04f351 Compare April 29, 2020 15:05
devversion
devversion approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 29, 2020
@josephperrott josephperrott removed their assignment Apr 29, 2020
@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 30, 2020
@jelbourn
Copy link
Member

@josephperrott feel free to add "merge ready" for build stuff like this

@jelbourn jelbourn merged commit 15efb67 into angular:master Apr 30, 2020
jelbourn pushed a commit that referenced this pull request Apr 30, 2020
@trik @jelbourn
build: update to rules_nodejs 1.6.0 (#19185)
bacd18b
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2020
@trik trik deleted the rules-nodejs-1.6.0 branch June 3, 2020 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trik @jelbourn @devversion @josephperrott @googlebot