build: prevent bazel from logging warning on each invocation #19298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each time ibazel is run, it logs something like: ``` INFO: Build completed successfully, 14 total actions ################################################################################ # Did you know iBazel can invoke programs like Gazelle, buildozer, and # # other BUILD file generators for you automatically based on bazel output? # # Documentation at: https://github.com/bazelbuild/bazel-watcher#output-runner # ################################################################################ iBazel [3:24PM]: Use default regex ``` These changes avoid the annoying banner by adding a `.bazel_fix_commands.json` file according to https://github.com/bazelbuild/bazel-watcher#output-runner. Note that we it seems like we should be able to do the same by passing the `--run_output=false` flag, but I wasn't able to get it to work through the `.bazelrc`.
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
May 11, 2020
|
I don't know whether we should file an issue, because it's documented which makes me think that it works this way on purpose. |
|
I don't think we should file an issue for the feature they are advertising for, but rather we should file an issue for the "ad banner" that is undesired in some Bazel projects. A way to reasonably disable the advertisement is not documented either. |
mmalerba
pushed a commit
that referenced
this pull request
May 15, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time ibazel is run, it logs something like:
These changes avoid the annoying banner by adding a
.bazel_fix_commands.jsonfile according to https://github.com/bazelbuild/bazel-watcher#output-runner. Note that we it seems like we should be able to do the same by passing the--run_output=falseflag, but I wasn't able to get it to work through the.bazelrc.