test: add characterization tests for DocsMarkedRenderer #19413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
atscott
force-pushed
the
docsmarkedrenderertest
branch
from
d6072a2 to
249ea4b
Compare
annieyw
previously requested changes
May 21, 2020
| { | ||
| "example": "exampleName", | ||
| "file": "example-html.html", | ||
| "region": "some-region", |
There was a problem hiding this comment.
the final , messes up JSON.parse (one of the few things that was wrong with the new API
for DocsMarkedRenderer#html)
I'll submit a patch to fix them
There was a problem hiding this comment.
👍 I'll wait for that fix before I submit this.
Edit: Actually, it might be good for this to go in first so you can update the test and verify your fix works.
These tests are meant to simply document and verify the existing behavior of the DocsMarkedRenderer. They aren't necessarily meant to be a good example of unit testing best-practices. A characterization test "is a means to describe (characterize) the actual behavior of an existing piece of software, and therefore protect existing behavior of legacy code against unintended changes via automated testing." https://en.wikipedia.org/wiki/Characterization_test
atscott
force-pushed
the
docsmarkedrenderertest
branch
from
249ea4b to
6aa8d6f
Compare
mmalerba
added
lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
May 22, 2020
These tests are meant to simply document and verify the existing behavior of the DocsMarkedRenderer. They aren't necessarily meant to be a good example of unit testing best-practices. A characterization test "is a means to describe (characterize) the actual behavior of an existing piece of software, and therefore protect existing behavior of legacy code against unintended changes via automated testing." https://en.wikipedia.org/wiki/Characterization_test
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are meant to simply document and verify the existing
behavior of the DocsMarkedRenderer. They aren't necessarily meant to be
a good example of unit testing best-practices.
A characterization test "is a means to describe (characterize) the actual behavior of an existing piece of software, and therefore protect existing behavior of legacy code against unintended changes via automated testing."
https://en.wikipedia.org/wiki/Characterization_test