Skip to content

build: remove ng-dev typescript configuration workaround #19415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We recently added a workaround to support having a ng-dev
configuration written in TypeScript. The ng-dev tool now
automatically sets up ts-node when needed, so we can remove
the workaround.

Additionally, we can replace the merge branch determining logic
as the script has been moved upstream. It has been also improved
to no longer rely on Git but rather on the NPM registry.

We recently added a workaround to support having a `ng-dev`
configuration written in TypeScript. The `ng-dev` tool now
automatically sets up `ts-node` when needed, so we can remove
the workaround.

Additionally, we can replace the merge branch determining logic
as the script has been moved upstream. It has been also improved
to no longer rely on Git but rather on the NPM registry.
@devversion devversion requested review from jelbourn and a team as code owners May 21, 2020 19:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 21, 2020
@devversion devversion added merge safe target: major This PR is targeted for the next major release labels May 21, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels May 21, 2020
@jelbourn jelbourn merged commit 8dbee4e into angular:master May 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants