fix: focus monitor-based styles not working in some cases inside shadow dom #19422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
19414/focus-monitor-calls
branch
from
059f087 to
30f6912
Compare
…ow dom A while ago event delegation was implemented for the focus monitor which has some special behavior where it has to bind its events to the closest shadow root in order for them to work correctly. The problem is that a lot of our `FocusMonitor.focus` calls are very early in the component lifecycle which means that might not have been put into the shadow DOM yet. These changes move the `monitor` calls to `ngAfterViewInit` to resolve the issue. Fixes angular#19414.
crisbeto
force-pushed
the
19414/focus-monitor-calls
branch
from
30f6912 to
bbfd25b
Compare
andrewseguin
added
target: minor
|
Good progress on this one. I see its merged to master. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago event delegation was implemented for the focus monitor which has some special behavior where it has to bind its events to the closest shadow root in order for them to work correctly. The problem is that a lot of our
FocusMonitor.focuscalls are very early in the component lifecycle which means that might not have been put into the shadow DOM yet. These changes move themonitorcalls tongAfterViewInitto resolve the issue.Fixes #19414.