-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: fix bazel version #19553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix bazel version #19553
Conversation
Executing tests on MacOS Catalina runs into issues with bazel 3.0.0. Bazel will use the version specified in the .bazelversion file and hence no matter what is installed, if 3.0.0 is available that will run. d4d12a9 changed WORKSPACE and .bazelversion from 3.1.0 to 3.0.0 which looks to have introduced this issue. Changing back to 3.1.0 fixes tests on Catalina
@devversion haven't had a chance to check on windows or linux. |
do we know what specifically caused this issue in Bazel? I agree though that we should generally update. I'm surprised I rolled back accidentally (those changes shouldn't be part of the commit) |
@devversion it happens I haven't had a chance to dig into it and a quick google search doesn't come up with anything. My best guess is that the bazel version wasn't working with the tool chain? c3fbcf6 updated everything to 3.1.0 but it was executing tests with 3.0.0. I found the error via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Executing tests on MacOS Catalina runs into issues with bazel 3.0.0.
Bazel will use the version specified in the .bazelversion file and hence
no matter what is installed, if 3.0.0 is available that will run.
d4d12a9 changed WORKSPACE and .bazelversion from 3.1.0 to 3.0.0 which
looks to have introduced this issue.
Changing back to 3.1.0 fixes tests on Catalina