Skip to content

build: fix bazel version #19553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Conversation

andy9775
Copy link
Contributor

@andy9775 andy9775 commented Jun 5, 2020

Executing tests on MacOS Catalina runs into issues with bazel 3.0.0.
Bazel will use the version specified in the .bazelversion file and hence
no matter what is installed, if 3.0.0 is available that will run.

d4d12a9 changed WORKSPACE and .bazelversion from 3.1.0 to 3.0.0 which
looks to have introduced this issue.

Changing back to 3.1.0 fixes tests on Catalina

Executing tests on MacOS Catalina runs into issues with bazel 3.0.0.
Bazel will use the version specified in the .bazelversion file and hence
no matter what is installed, if 3.0.0 is available that will run.

d4d12a9 changed WORKSPACE and .bazelversion from 3.1.0 to 3.0.0 which
looks to have introduced this issue.

Changing back to 3.1.0 fixes tests on Catalina
@andy9775 andy9775 requested review from jelbourn and a team as code owners June 5, 2020 23:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 5, 2020
@andy9775
Copy link
Contributor Author

andy9775 commented Jun 5, 2020

@devversion haven't had a chance to check on windows or linux.

@devversion
Copy link
Member

do we know what specifically caused this issue in Bazel? I agree though that we should generally update. I'm surprised I rolled back accidentally (those changes shouldn't be part of the commit)

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 5, 2020
@andy9775
Copy link
Contributor Author

andy9775 commented Jun 6, 2020

@devversion it happens

I haven't had a chance to dig into it and a quick google search doesn't come up with anything. My best guess is that the bazel version wasn't working with the tool chain? c3fbcf6 updated everything to 3.1.0 but it was executing tests with 3.0.0.

I found the error via git bisect so I have no direct source

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 4346b52 into angular:master Jun 8, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants