fix(input): incorrectly handling nested themes #19637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color selectors in the input theme were too broad which means that they won't work correctly if themes are nested. The issue can be reproduced by placing a form field inside a tab group with an `accent` palette. These changes fix the issue by making the selector more specific.
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Jun 15, 2020
jelbourn
pushed a commit
that referenced
this pull request
Jun 29, 2020
The color selectors in the input theme were too broad which means that they won't work correctly if themes are nested. The issue can be reproduced by placing a form field inside a tab group with an `accent` palette. These changes fix the issue by making the selector more specific.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color selectors in the input theme were too broad which means that they won't work correctly if themes are nested. The issue can be reproduced by placing a form field inside a tab group with an
accentpalette. These changes fix the issue by making the selector more specific.