Skip to content

chore: bump version to 10.0.0-rc.2 w/ changelog #19651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@andrewseguin andrewseguin requested a review from a team as a code owner June 15, 2020 17:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2020
CHANGELOG.md Outdated
| | |
| ---------- | --------------------- |
| bug fix | **benchmark:** fix license header and correct test descriptions ([#19596](https://github.com/angular/components/issues/19596)) ([0d266e2](https://github.com/angular/components/commit/0d266e2)) |
| bug fix | **benchmark:** fix license header, remove a11y import, and remove [@title](https://github.com/title) doc ([#19582](https://github.com/angular/components/issues/19582)) ([7d4fcd5](https://github.com/angular/components/commit/7d4fcd5)) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these benchmark changes should be in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed - removed

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Jun 15, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2020
@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jun 15, 2020
@andrewseguin andrewseguin merged commit b089abe into angular:master Jun 15, 2020
andrewseguin added a commit that referenced this pull request Jun 15, 2020
* chore: bump version to 10.0.0-rc.2 w/ changelog

* remove benchmark
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants