fix(list): determine if option value changed (#19828) #19870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swseverance
requested review from
crisbeto,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
|
Looks like the lint stage failed. I thought code formatting happened as part of a git-hook. Which command should I run to do the code formatting? |
|
Should just be |
When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.
swseverance
force-pushed
the
bugfix/mat-selection-list
branch
from
71fcff6 to
e269b2a
Compare
devversion
added
lgtm
target: patch
crisbeto
added
the
P3
wagnermaciel
pushed a commit
that referenced
this pull request
Aug 20, 2020
When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated. (cherry picked from commit f9c5ffe)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value of a
mat-list-optionis updated, themat-selection-listcompareWithfunction should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.