docs(tree): fix example that shows empty checklists as selected #20106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We determine whether a node is selected in the checklist example using `Array.prototype.every`, but the problem is that `every` returns true for empty arrays which looks weird in our example. Fixes angular#20085.
crisbeto
added
docs
googlebot
added
the
cla: yes
mmalerba
reviewed
Jul 27, 2020
| this.checklistSelection.isSelected(child) | ||
| ); | ||
| const descAllSelected = descendants.length > 0 && descendants.every(child => { | ||
| return this.checklistSelection.isSelected(child); |
There was a problem hiding this comment.
nit: why add the {} and return?
There was a problem hiding this comment.
I just find it more readable compared to the multi-line arrow function with an implicit return.
There was a problem hiding this comment.
I prefer the implicit return, but I don't think we have an official style on way or the other
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We determine whether a node is selected in the checklist example using
Array.prototype.every, but the problem is thateveryreturns true for empty arrays which looks weird in our example.Fixes #20085.