Skip to content

test(mdc-checkbox): add performance tests for mdc-checkbox #20129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2020
Merged
1 change: 0 additions & 1 deletion test/benchmarks/material/card/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export class CardBenchmarkApp {
hide() { this.isVisible = false; }
}


@NgModule({
declarations: [CardBenchmarkApp],
imports: [
Expand Down
5 changes: 4 additions & 1 deletion test/benchmarks/material/checkbox/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ import {MatCheckboxModule} from '@angular/material/checkbox';
styleUrls: ['//src/material/core/theming/prebuilt/indigo-pink.css'],
})
export class CheckboxBenchmarkApp {

// isChecked is used to maintain the buttons checked state even after it has been hidden. This is
// used, for example, when we want to test the render speed of a checked vs unchecked checkbox.

isChecked = false;
isVisible = false;
isIndeterminate = false;
Expand All @@ -39,7 +43,6 @@ export class CheckboxBenchmarkApp {
toggleIsChecked() { this.isChecked = !this.isChecked; }
}


@NgModule({
declarations: [CheckboxBenchmarkApp],
imports: [
Expand Down
1 change: 0 additions & 1 deletion test/benchmarks/material/chips/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export class ChipsBenchmarkApp {
hideMultiple() { this.isMultipleVisible = false; }
}


@NgModule({
declarations: [ChipsBenchmarkApp],
imports: [
Expand Down
1 change: 0 additions & 1 deletion test/benchmarks/material/form-field/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export class FormFieldBenchmarkApp {
}
}


@NgModule({
declarations: [FormFieldBenchmarkApp],
imports: [
Expand Down
1 change: 0 additions & 1 deletion test/benchmarks/material/radio/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export class RadioBenchmarkApp {
hideTen() { this.isTenVisible = false; }
}


@NgModule({
declarations: [RadioBenchmarkApp],
imports: [
Expand Down
1 change: 0 additions & 1 deletion test/benchmarks/material/slide-toggle/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export class SlideToggleBenchmarkApp {
hide() { this.isVisible = false; }
}


@NgModule({
declarations: [SlideToggleBenchmarkApp],
imports: [
Expand Down
1 change: 0 additions & 1 deletion test/benchmarks/material/table/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export class TableBenchmarkApp {
showTenRowsTwentyCols() { this.isTenRowsTwentyColsVisible = true; }
}


@NgModule({
declarations: [BasicTable, TableBenchmarkApp],
imports: [
Expand Down
2 changes: 0 additions & 2 deletions test/benchmarks/mdc/button/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,12 @@ export class ButtonBenchmarkApp {
hide() { this.isVisible = false; }
}


@NgModule({
declarations: [ButtonBenchmarkApp],
imports: [
BrowserModule,
MatButtonModule,
],
providers: [],
bootstrap: [ButtonBenchmarkApp],
})
export class AppModule {}
1 change: 0 additions & 1 deletion test/benchmarks/mdc/card/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export class CardBenchmarkApp {
hide() { this.isVisible = false; }
}


@NgModule({
declarations: [CardBenchmarkApp],
imports: [
Expand Down
22 changes: 22 additions & 0 deletions test/benchmarks/mdc/checkbox/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
load("@npm_angular_dev_infra_private//benchmark/component_benchmark:component_benchmark.bzl", "component_benchmark")

# TODO(wagnermaciel): Update this target to provide indigo-pink in a way that doesn't require having to import it with
# stylesUrls inside the components once `component_benchmark` supports asset injection.

component_benchmark(
name = "benchmark",
driver = ":checkbox.perf-spec.ts",
driver_deps = [
"@npm//@angular/dev-infra-private",
"@npm//protractor",
"@npm//@types/jasmine",
],
ng_deps = [
"@npm//@angular/core",
"@npm//@angular/platform-browser",
"//src/material-experimental/mdc-checkbox",
],
ng_srcs = [":app.module.ts"],
prefix = "",
styles = ["//src/material-experimental/mdc-theming:indigo_pink_prebuilt"],
)
54 changes: 54 additions & 0 deletions test/benchmarks/mdc/checkbox/app.module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/**
* @license
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/

import {Component, NgModule, ViewEncapsulation} from '@angular/core';
import {BrowserModule} from '@angular/platform-browser';
import {MatCheckboxModule} from '@angular/material-experimental/mdc-checkbox';

/** component: mdc-checkbox */

@Component({
selector: 'app-root',
template: `
<button id="show" (click)="show()">Show</button>
<button id="hide" (click)="hide()">Hide</button>
<button id="indeterminate" (click)="indeterminate()">Indeterminate</button>

<mat-checkbox *ngIf="isVisible"
[checked]="isChecked"
[indeterminate]="isIndeterminate"
(change)="toggleIsChecked()">
Check me!</mat-checkbox>
`,
encapsulation: ViewEncapsulation.None,
styleUrls: ['//src/material-experimental/mdc-theming/prebuilt/indigo-pink.css'],
})
export class CheckboxBenchmarkApp {

// isChecked is used to maintain the buttons checked state even after it has been hidden. This is
// used, for example, when we want to test the render speed of a checked vs unchecked checkbox.

isChecked = false;
isVisible = false;
isIndeterminate = false;

show() { this.isVisible = true; }
hide() { this.isVisible = false; }
indeterminate() { this.isIndeterminate = true; }
toggleIsChecked() { this.isChecked = !this.isChecked; }
}

@NgModule({
declarations: [CheckboxBenchmarkApp],
imports: [
BrowserModule,
MatCheckboxModule,
],
bootstrap: [CheckboxBenchmarkApp],
})
export class AppModule {}
105 changes: 105 additions & 0 deletions test/benchmarks/mdc/checkbox/checkbox.perf-spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
/**
* @license
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/

import {$, browser} from 'protractor';
import {runBenchmark} from '@angular/dev-infra-private/benchmark/driver-utilities';

describe('checkbox performance benchmarks', () => {
beforeAll(() => {
browser.rootEl = '#root';
});

it('renders a checked checkbox', async() => {
await runBenchmark({
id: 'checkbox-render-checked',
url: '',
ignoreBrowserSynchronization: true,
params: [],
setup: async () => {
await $('#show').click();
await $('mat-checkbox').click();
},
prepare: async () => {
expect(await $('mat-checkbox input').isSelected())
.toBe(true, 'The checkbox should be in a selected state.');
await $('#hide').click();
},
work: async () => await $('#show').click()
});
});

it('renders an unchecked checkbox', async() => {
await runBenchmark({
id: 'checkbox-render-unchecked',
url: '',
ignoreBrowserSynchronization: true,
params: [],
setup: async() => await $('#show').click(),
prepare: async () => {
expect(await $('mat-checkbox input').isSelected())
.toBe(false, 'The checkbox should be in an unselected state.');
await $('#hide').click();
},
work: async () => await $('#show').click()
});
});

it('renders an indeterminate checkbox', async() => {
await runBenchmark({
id: 'checkbox-render-indeterminate',
url: '',
ignoreBrowserSynchronization: true,
params: [],
setup: async() => {
await $('#show').click();
await $('#indeterminate').click();
},
prepare: async () => {
expect(await $('mat-checkbox input').getAttribute('indeterminate'))
.toBe('true', 'The checkbox should be in an indeterminate state');
await $('#hide').click();
},
work: async () => await $('#show').click()
});
});

it('updates from unchecked to checked', async() => {
await runBenchmark({
id: 'checkbox-click-unchecked-to-checked',
url: '',
ignoreBrowserSynchronization: true,
params: [],
setup: async () => {
await $('#show').click();
await $('mat-checkbox').click();
},
prepare: async () => {
await $('mat-checkbox').click();
expect(await $('mat-checkbox input').isSelected())
.toBe(false, 'The checkbox should be in an unchecked state.');
},
work: async () => await $('mat-checkbox').click(),
});
});

it('updates from checked to unchecked', async() => {
await runBenchmark({
id: 'checkbox-click-checked-to-unchecked',
url: '',
ignoreBrowserSynchronization: true,
params: [],
setup: async () => await $('#show').click(),
prepare: async () => {
await $('mat-checkbox').click();
expect(await $('mat-checkbox input').isSelected())
.toBe(true, 'The checkbox should be in a checked state.');
},
work: async () => await $('mat-checkbox').click(),
});
});
});