Skip to content

refactor(cdk-experimental/menu): export Menu interface injection token and MenuStack #20130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

andy9775
Copy link
Contributor

Any third-party wanting to extend CdkMenu or CdkMenuBar will need to update the providers array
with the concrete component to inject for the Menu interface as well as act as a provider for the
MenuStack therefore requiring access to the injection token and MenuStack instance.

…n and MenuStack

Any third-party wanting to extend CdkMenu or CdkMenuBar will need to update the providers array
with the concrete component to inject for the Menu interface as well as act as a provider for the
MenuStack therefore requiring access to the injection token and MenuStack instance.
@andy9775 andy9775 requested a review from jelbourn as a code owner July 29, 2020 18:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 29, 2020
@andy9775 andy9775 requested a review from teflonwaffles July 29, 2020 18:26
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jul 29, 2020
@jelbourn jelbourn merged commit 37f4a7a into angular:master Jul 29, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants