Skip to content

test(mdc-chips): add performance tests for mdc-chips #20131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2020

Conversation

wagnermaciel
Copy link
Contributor

Context

This branch is checked out of #20032 because it needs the changes to material-experimental's indigo-pink theme.

@wagnermaciel wagnermaciel requested review from mmalerba and a team as code owners July 29, 2020 18:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 29, 2020

<mat-chip *ngIf="isSingleVisible">One</mat-chip>

<mat-chip-set *ngIf="isMultipleVisible">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from mat-chip-set, we also have a mat-chip-grid and mat-chip-listbox that should probably cover. Furthermore, there are other components like the chip avatar and remove button that aren't represented here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I am a bit confused with mat-chip-grid and perhaps you could help me out here. If I do not provide an input within the mat-chip-grid alongside the mat-chip-rows the rows do not work properly. Am I doing something wrong or is this intentional?

Here is a link to the html for this

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 3, 2020
@wagnermaciel wagnermaciel removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Aug 5, 2020
@mmalerba mmalerba merged commit cd433a4 into angular:master Aug 6, 2020
mmalerba pushed a commit that referenced this pull request Aug 6, 2020
* fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink

* fixup! fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink

* test(mdc-chips): add performance tests for mdc-chips

* fix(mdc-chips-benchmark): remove unnecessary providers

* fix(mdc-chips-benchmark): add tests for grid and listbox

* fixup! fix(mdc-chips-benchmark): add tests for grid and listbox

(cherry picked from commit cd433a4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2020
@wagnermaciel wagnermaciel deleted the mdc-chips-benchmark branch January 14, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants