-
Notifications
You must be signed in to change notification settings - Fork 6.8k
test(mdc-chips): add performance tests for mdc-chips #20131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
<mat-chip *ngIf="isSingleVisible">One</mat-chip> | ||
|
||
<mat-chip-set *ngIf="isMultipleVisible"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from mat-chip-set
, we also have a mat-chip-grid
and mat-chip-listbox
that should probably cover. Furthermore, there are other components like the chip avatar and remove button that aren't represented here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I am a bit confused with mat-chip-grid
and perhaps you could help me out here. If I do not provide an input within the mat-chip-grid
alongside the mat-chip-row
s the rows do not work properly. Am I doing something wrong or is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ff6357b
to
dac3d76
Compare
* fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink * fixup! fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink * test(mdc-chips): add performance tests for mdc-chips * fix(mdc-chips-benchmark): remove unnecessary providers * fix(mdc-chips-benchmark): add tests for grid and listbox * fixup! fix(mdc-chips-benchmark): add tests for grid and listbox (cherry picked from commit cd433a4)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Context
This branch is checked out of #20032 because it needs the changes to material-experimental's indigo-pink theme.