Skip to content

test(mdc-slide-toggle): add performance tests for mdc-slide-toggle #20133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2020
Merged

test(mdc-slide-toggle): add performance tests for mdc-slide-toggle #20133

merged 3 commits into from
Aug 6, 2020

Conversation

wagnermaciel
Copy link
Contributor

Context

This branch is checked out of #20032 because it needs the changes to material-experimental's indigo-pink theme.

@wagnermaciel wagnermaciel requested review from mmalerba and a team as code owners July 29, 2020 19:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 29, 2020
crisbeto
crisbeto approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the lgtm label Jul 30, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 3, 2020
@wagnermaciel wagnermaciel added merge safe and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Aug 5, 2020
@mmalerba mmalerba merged commit e83dbb1 into angular:master Aug 6, 2020
mmalerba pushed a commit that referenced this pull request Aug 6, 2020
@wagnermaciel @mmalerba
test(mdc-slide-toggle): add performance tests for mdc-slide-toggle (#…
82db589 
…20133)

* fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink

* test(mdc-slide-toggle): add performance tests for mdc-slide-toggle

* fix(mdc-slide-toggle-benchmark): remove unnecessary provider

(cherry picked from commit e83dbb1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2020
@wagnermaciel wagnermaciel deleted the mdc-slide-toggle branch January 14, 2021 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wagnermaciel @crisbeto @devversion @googlebot @mmalerba