fix: add non-null assertions for non-nullable input bindings #20136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Due to a bug in the template type checker, binding expressions that include `undefined` in their type which are bound to directive inputs that don't accept `undefined` would not be reported as an error, if the directive declares at least one coercion member using `ngAcceptInputType`. angular/angular#38273 fixes this bug, which uncovers some template issues. Long-term, it would be best if the directives would be updated to include `undefined` in an input's type as appropriate. This would require a larger effort and is likely to introduce some breaking changes to public API.
crisbeto
approved these changes
Jul 30, 2020
crisbeto
added
lgtm
action: merge
|
Going to do a presubmit for this one anyway out of an abundance of caution |
mmalerba
added
target: minor
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Aug 5, 2020
The changes in angular/components#20136 are required to allow the framework tests to succeed.
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Aug 6, 2020
The changes in angular/components#20136 are required to allow the framework tests to succeed. PR Close #38273
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Aug 7, 2020
…#38273) The changes in angular/components#20136 are required to allow the framework tests to succeed. PR Close angular#38273
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Aug 7, 2020
…#38378) The changes in angular/components#20136 are required to allow the framework tests to succeed. PR Close #38273 PR Close #38378
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the template type checker, binding expressions that include
undefinedin their type which are bound to directive inputs that don't acceptundefinedwould not be reported as an error, if the directive declares atleast one coercion member using
ngAcceptInputType. angular/angular#38273fixes this bug, which uncovers some template issues.
Long-term, it would be best if the directives would be updated to include
undefinedin an input's type as appropriate. This would require a largereffort and is likely to introduce some breaking changes to public API.