-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Hugoer/material table #20149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hugoer/material table #20149
Conversation
Sort correctly when column information has string and numeric values Fixes angular#20140
Sort correctly when column information has string and numeric values Fixes angular#20140
Sort correctly when column information has string and numeric values
Sort correctly when column information has string and numeric values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR also missing a proper title and description, and the commit titles should be a bit more descriptive.
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
Please, tell me if it is needed more information and i would add it. Sorry about number of commits, i did it from mobile because of i am not at home for some days. |
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
The commit title still seems pretty generic and won't tell people much when it makes it to the changelog. Maybe something along the lines of "fix(table): correctly sort columns with mixed data types"? |
Done! i did a git commit amend, it is right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Commit message fixup: use message from last commit when squashing ( |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text