refactor(cdk-experimental/menu): move listeners from host object to host listener decorator #20164
Conversation
…ost listener decorator Some of the Cdk directives are expected to be extended by some subclasses (e.g. material). In Ivy the host metadata will be merged whereas in ViewEngine it will be overridden forcing duplication of listeners in the host object on the subclass which results in double listeners in Ivy. Moving to @HostListener prevents having to duplicate them in subclasses.
googlebot
added
the
cla: yes
| @@ -248,6 +256,11 @@ export class CdkMenuBar extends CdkMenuGroup implements Menu, AfterContentInit, | |||
| return this.orientation === 'horizontal'; | |||
| } | |||
|
|
|||
| // In Ivy the `host` metadata will be merged, whereas in ViewEngine it is overridden. In order | |||
| // to avoid double event listeners, we need to use `HostListener`. Once Ivy is the default, we | |||
There was a problem hiding this comment.
You'll need a stronger condition for shifting it back -- I'd say ViewEngine needs to be deprecated before you could do this.
There was a problem hiding this comment.
This is the comment we have throughout the library for this pattern, we can leave it as is (even though it's actually that ViewEngine needs to be deleted before we can do this)
| @@ -248,6 +256,11 @@ export class CdkMenuBar extends CdkMenuGroup implements Menu, AfterContentInit, | |||
| return this.orientation === 'horizontal'; | |||
| } | |||
|
|
|||
| // In Ivy the `host` metadata will be merged, whereas in ViewEngine it is overridden. In order | |||
| // to avoid double event listeners, we need to use `HostListener`. Once Ivy is the default, we | |||
There was a problem hiding this comment.
This is the comment we have throughout the library for this pattern, we can leave it as is (even though it's actually that ViewEngine needs to be deleted before we can do this)
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Some of the Cdk directives are expected to be extended by some subclasses (e.g. material). In Ivy
the host metadata will be merged whereas in ViewEngine it will be overridden forcing duplication of
listeners in the host object on the subclass which results in double listeners in Ivy. Moving to
@HostListener prevents having to duplicate them in subclasses.