Skip to content

chore: bump version to 10.1.2 w/ changelog #20168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Aug 3, 2020

No description provided.

@jelbourn jelbourn added merge safe target: patch This PR is targeted for the next patch release labels Aug 3, 2020
@jelbourn jelbourn requested a review from mmalerba August 3, 2020 19:18
@jelbourn jelbourn requested a review from a team as a code owner August 3, 2020 19:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 3, 2020

| | |
| ---------- | --------------------- |
| feature | add MDC-based mat-option and mdc-core entry point ([#19557](https://github.com/angular/components/issues/19557)) ([3d0f827](https://github.com/angular/components/commit/3d0f827)) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be feature for a patch release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't follow semver for the experimental packages

CHANGELOG.md Outdated
| bug fix | **clipboard:** scroll position changing while copying on some browsers ([#20073](https://github.com/angular/components/issues/20073)) ([f58407d](https://github.com/angular/components/commit/f58407d)) |
| bug fix | **overlay:** only dispatch position change event if requested ([#19785](https://github.com/angular/components/issues/19785)) ([37b9664](https://github.com/angular/components/commit/37b9664)) |
| bug fix | **portal:** running change detection before nodes have been moved to outlet ([#16407](https://github.com/angular/components/issues/16407)) ([30da7e1](https://github.com/angular/components/commit/30da7e1)), closes [#16346](https://github.com/angular/components/issues/16346) |
| bug fix | **scrolling:** virtual scroll not accounting for margin when measuring range ([#19852](https://github.com/angular/components/issues/19852)) ([5892285](https://github.com/angular/components/commit/5892285)), closes [#19851](https://github.com/angular/components/issues/19851) |
Copy link
Member

@devversion devversion Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the ones above should be in CDK. The commits just didn't set an explicit package, so we fall back to material.

We'll hopefully have linting for this soon (blocked on dev-infra having an organization-wide standard) but it might help if we just not fall back to material, but add them to a section like needs cleanup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2020
@jelbourn jelbourn force-pushed the release-stage/10.1.2 branch from f3f8a4f to 7bb8342 Compare August 3, 2020 19:55
@jelbourn jelbourn force-pushed the release-stage/10.1.2 branch from 7bb8342 to c044ff9 Compare August 3, 2020 19:57
@jelbourn jelbourn merged commit 7b0bb2c into angular:10.1.x Aug 3, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants