-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: bump version to 10.1.2 w/ changelog #20168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
| | | | ||
| ---------- | --------------------- | | ||
| feature | add MDC-based mat-option and mdc-core entry point ([#19557](https://github.com/angular/components/issues/19557)) ([3d0f827](https://github.com/angular/components/commit/3d0f827)) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be feature for a patch release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally don't follow semver for the experimental packages
CHANGELOG.md
Outdated
| bug fix | **clipboard:** scroll position changing while copying on some browsers ([#20073](https://github.com/angular/components/issues/20073)) ([f58407d](https://github.com/angular/components/commit/f58407d)) | | ||
| bug fix | **overlay:** only dispatch position change event if requested ([#19785](https://github.com/angular/components/issues/19785)) ([37b9664](https://github.com/angular/components/commit/37b9664)) | | ||
| bug fix | **portal:** running change detection before nodes have been moved to outlet ([#16407](https://github.com/angular/components/issues/16407)) ([30da7e1](https://github.com/angular/components/commit/30da7e1)), closes [#16346](https://github.com/angular/components/issues/16346) | | ||
| bug fix | **scrolling:** virtual scroll not accounting for margin when measuring range ([#19852](https://github.com/angular/components/issues/19852)) ([5892285](https://github.com/angular/components/commit/5892285)), closes [#19851](https://github.com/angular/components/issues/19851) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the ones above should be in CDK. The commits just didn't set an explicit package, so we fall back to material
.
We'll hopefully have linting for this soon (blocked on dev-infra having an organization-wide standard) but it might help if we just not fall back to material, but add them to a section like needs cleanup
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f3f8a4f
to
7bb8342
Compare
7bb8342
to
c044ff9
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.