build: create script for building docs-content #20198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a script that builds the docs-content. We also use that script in the our CI setup to reduce duplication. The script will not pack the package by default, as that is up to the consumer of the script. It's totally fine just adding a package directory to a project (similar to a tarball).
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
pushed a commit
that referenced
this pull request
Aug 12, 2020
Creates a script that builds the docs-content. We also use that script in the our CI setup to reduce duplication. The script will not pack the package by default, as that is up to the consumer of the script. It's totally fine just adding a package directory to a project (similar to a tarball). (cherry picked from commit 53c9441)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a script that builds the docs-content. We also use
that script in the our CI setup to reduce duplication.
The script will not pack the package by default, as that is
up to the consumer of the script and we do don't do it
for other release packages. It's totally fine just adding a package
directory to a project (similar to a tarball).
My concern with packing in those scripts is that it will unnecessarily
slow down builds on CI and packing is not necessarily fast for large packages