build: fix release output containing invalid imports sometimes #20201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
merge safe
P2
devversion
force-pushed
the
build/fix-npm-release-output-broken-imports
branch
2 times, most recently
from
c9a8e95 to
ac53ac9
Compare
A very subtle issue has surfaced in our release output. Based on previous builds that have been performed locally by the caretaker performing the release, the release output might differ and contain invalid module imports that break ES2015 output. Notably the es2015 output is not primarily used by the CLI. It uses the flat ES2015 output instead. The issue surfaces because of a bug in `@bazel/typescript` where the `moduleName` for source files is leaking between TSC worker runs. This means that source files are incorrectly referenced by module name, instead of relative path when the prodmode ES2015 output is built. Deep paths to source files are not supported as per Angular Package format. We patch the fix that is pending upstream to ensure our release output works: bazelbuild/rules_typescript#504. Once the fix upstream lands (which might take quite some time; given g3 sync and sync with the rules_nodejs repository), we can remove the patch and update to the latest version of `@bazel/typescript`. Fixes angular#20179.
devversion
force-pushed
the
build/fix-npm-release-output-broken-imports
branch
from
ac53ac9 to
e701bae
Compare
mmalerba
pushed a commit
that referenced
this pull request
Aug 5, 2020
A very subtle issue has surfaced in our release output. Based on previous builds that have been performed locally by the caretaker performing the release, the release output might differ and contain invalid module imports that break ES2015 output. Notably the es2015 output is not primarily used by the CLI. It uses the flat ES2015 output instead. The issue surfaces because of a bug in `@bazel/typescript` where the `moduleName` for source files is leaking between TSC worker runs. This means that source files are incorrectly referenced by module name, instead of relative path when the prodmode ES2015 output is built. Deep paths to source files are not supported as per Angular Package format. We patch the fix that is pending upstream to ensure our release output works: bazelbuild/rules_typescript#504. Once the fix upstream lands (which might take quite some time; given g3 sync and sync with the rules_nodejs repository), we can remove the patch and update to the latest version of `@bazel/typescript`. Fixes #20179.
mmalerba
added a commit
that referenced
this pull request
Aug 5, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very subtle issue has surfaced in our release output. Based on
previous builds that have been performed locally by the caretaker
performing the release, the release output might differ and contain
invalid module imports that break ES2015 output.
Notably the es2015 output is not primarily used by the CLI. It uses
the flat ES2015 output instead.
The issue surfaces because of a bug in
@bazel/typescriptwhere themoduleNamefor source files is leaking between TSC worker runs. Thismeans that source files are incorrectly referenced by module name,
instead of relative path when the prodmode ES2015 output is built.
Deep paths to source files are not supported as per Angular Package format.
We patch the fix that is pending upstream to ensure our release output
works: bazelbuild/rules_typescript#504. Once the
fix upstream lands (which might take quite some time; given g3 sync and
sync with the rules_nodejs repository), we can remove the patch and
update to the latest version of
@bazel/typescript.Fixes #20179.