fix(dialog): backdrop not detaching if container view is destroyed #20232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently refactored the Material dialog so that it can be used as base class for the MDC based dialog. For this, we slightly changed how animations are announced to the corresponding dialog ref. This was done because the MDC dialog does not use Angular animations. It looks like we slightly regressed in cases where the dialog container view is destroyed immediately upon dialog close. This is because we accidentally no longer notify the dialog ref if the dialog animation state goes from `*` to `void`. Currently we only handle `*` to `exit` while we should also handle the `void` state. This issue has not surfaced in any of our tests, in the dev-app but one screenshot test inside g3 seems flaky after the dialog refactor.
devversion
added
P2
googlebot
added
the
cla: yes
devversion
commented
Aug 7, 2020
…oyed Add same test to MDC dialog
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently refactored the Material dialog so that it can be used
as base class for the MDC based dialog. For this, we slightly changed
how animations are announced to the corresponding dialog ref. This
was done because the MDC dialog does not use Angular animations.
It looks like we slightly regressed in cases where the dialog container view
is destroyed immediately upon dialog close. This is because we accidentally
no longer notify the dialog ref if the dialog animation state goes from
*tovoid. Currently we only handle*toexitwhile we should also handle thevoidstate.This issue has not surfaced in any of our tests, in the dev-app but one screenshot
test inside g3 seems flaky after the dialog refactor. This might fix it (given the
diff showing an extra backdrop if we interpret it correctly).