Skip to content

docs(form-field): implement error state getter in custom control example #20275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

docs(form-field): implement error state getter in custom control example #20275

merged 1 commit into from
Aug 18, 2020

Conversation

crisbeto
Copy link
Member

The custom input example wasn't showing how to implement the errorState getter which means that it can't show error messages.

Also fixes a place where we were using tabs for indentation.

Fixes #20269.

@crisbeto
docs(form-field): implement error state getter in custom control example
67b0956 
The custom input example wasn't showing how to implement the `errorState` getter which means that it can't show error messages.

Fixes angular#20269.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Aug 12, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner August 12, 2020 14:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2020
mmalerba
mmalerba approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 14, 2020
@wagnermaciel wagnermaciel merged commit d04a126 into angular:master Aug 18, 2020
wagnermaciel pushed a commit that referenced this pull request Aug 18, 2020
@crisbeto @wagnermaciel
docs(form-field): implement error state getter in custom control exam…
90f0434 
…ple (#20275)

The custom input example wasn't showing how to implement the `errorState` getter which means that it can't show error messages.

Fixes #20269.

(cherry picked from commit d04a126)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(COMPONENT): Custom input component incorrectly documented
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel