Skip to content

feat(material/tree): add test harness for MatTree #20323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2020
Merged

feat(material/tree): add test harness for MatTree #20323

merged 4 commits into from
Sep 23, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Aug 14, 2020

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 14, 2020
@annieyw annieyw force-pushed the mat-tree-harness branch 2 times, most recently from e62e777 to 9c689b7 Compare August 18, 2020 22:38
@annieyw annieyw marked this pull request as ready for review August 18, 2020 22:38
@annieyw
Copy link
Contributor Author

annieyw commented Aug 18, 2020

patched #20226 and #20145
commits start from "tree harness basic implementation ..."

mmalerba
mmalerba approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - marking as blocked until the pre-req PRs go through

@mmalerba mmalerba added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Aug 18, 2020
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Sep 14, 2020
@annieyw annieyw merged commit 5916800 into angular:master Sep 23, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Sep 24, 2020
@annieyw @wagnermaciel
feat(material/tree): add test harness for MatTree (angular#20323)
f9b8174 
* tree harness basic implementation - flat tree nodes throw error for getChildren/getDescendants

* only implement getNodes for tree for now

* fix imports and add entrypoint to config.bzl

* clean up duplicate host:{} and @HostBinding
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2020
@annieyw annieyw deleted the mat-tree-harness branch November 9, 2020 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annieyw @mmalerba @googlebot