Cdk stepper example refactor #20383
Merged
Cdk stepper example refactor #20383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…impler for this PR.
…le mode in a combobox.
…e consistent with the other example.
googlebot
added
the
cla: yes
crisbeto
added
docs
dev054
reviewed
Aug 21, 2020
| <div [style.display]="selected ? 'block' : 'none'"> | ||
| <ng-container [ngTemplateOutlet]="selected.content"></ng-container> | ||
| </div> | ||
| <div [ngTemplateOutlet]="selected ? selected.content : null"></div> |
There was a problem hiding this comment.
Excuse me, but could we use ng-container here so that no elements are rendered when it's not selected?
jelbourn
added
merge: fix commit message
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Sep 5, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old PR I forgot to get around to submitting earlier this summer. Just refactors the original cdk stepper example a bit taking into account the comments I got on my cdk linear stepper example.