feat(material/autocomplete): add panelClass default option #20429
Conversation
andrewseguin
added
P2
andrewseguin
requested review from
jelbourn,
crisbeto,
devversion and
mmalerba
googlebot
added
the
cla: yes
There was a problem hiding this comment.
Do the panel classes have to be on the mat-autocomplete-panel specifically or can they be one level up on the cdk-overlay-pane? If it's the latter, then this could be simplified by passing the panelClass value when creating the overlay here: https://github.com/angular/components/blob/master/src/material/autocomplete/autocomplete-trigger.ts#L637
andrewseguin
force-pushed
the
autocomplete-options
branch
from
0764e70 to
5730bb2
Compare
|
Sure - that works too - as long as its a parent class then we're good. I changed it so the options are now injected into the trigger as well and we pass through the panel class |
| @@ -2119,6 +2119,39 @@ describe('MatAutocomplete', () => { | |||
| })); | |||
| }); | |||
|
|
|||
| describe('with panel classes in the default options', () => { | |||
There was a problem hiding this comment.
Can you copy these tests into the MDC autocomplete too?
There was a problem hiding this comment.
Oh yeah for sure, good call
mmalerba
added
target: minor
…0429) * feat(material/autocomplete): add panelClass default option * update goldens * add tests to MDC
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Necessary for implementing the Google Material version internally, which relies on being able to provide options to the autocomplete to automatically apply a Google Material class