Skip to content

refactor(overlay): remove deprecated APIs for v11 #20511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2020
Merged

refactor(overlay): remove deprecated APIs for v11 #20511

merged 1 commit into from
Sep 23, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 8, 2020

Removes most of the deprecated APIs for v11 under cdk/overlay. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing ConnectedPositionStrategy which has a separate PR (#17519), and GlobalPositionStrategy.width and GlobalPositionStrategy.height, because they'll be trickier to land.

BREAKING CHANGES:

  • The OVERLAY_PROVIDERS constant has been removed. Import OverlayModule and use the providers directly instead.
  • _platform parameter of the OverlayContainer constructor is now required.
  • _platform parameter of the FullscreenOverlayContainer constructor is now required.
  • _location and _outsideClickDispatcher parameters of the OverlayRef constructor are now required.
  • _location and _outsideClickDispatcher parameters of the Overlay constructor are now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Sep 8, 2020
@crisbeto crisbeto added this to the 11.0.0 milestone Sep 8, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 8, 2020
@crisbeto crisbeto force-pushed the overlay-v11-breaking-changes branch from d48da68 to cf891c3 Compare September 8, 2020 13:52
mmalerba
mmalerba approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 9, 2020
@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 17, 2020
@jelbourn
Copy link
Member

Caretaker note: I remember that a nontrivial number of Google apps use OVERLAY_PROVIDERS from waaaay back in 2016 when it was necessary. We can potentially add a copybara transform to keep it in Google while removing it for npm.

@crisbeto crisbeto force-pushed the overlay-v11-breaking-changes branch 2 times, most recently from ceb42ab to d7a4e38 Compare September 17, 2020 18:51
@crisbeto
refactor(cdk/overlay): remove deprecated APIs for v11
7f987c6 
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that
these changes target primarily the breaking changes that should be easier to
land. I've left out removing `ConnectedPositionStrategy` which has a separate
PR (angular#17519), and `GlobalPositionStrategy.width` and
`GlobalPositionStrategy.height`, because they'll be trickier to land.

BREAKING CHANGES:
* The `OVERLAY_PROVIDERS` constant has been removed. Import
`OverlayModule` and use the providers directly instead.
* `_platform` parameter of the `OverlayContainer` constructor is now required.
* `_platform` parameter of the `FullscreenOverlayContainer` constructor is
now required.
* `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef`
constructor are now required.
* `_location` and `_outsideClickDispatcher` parameters of the `Overlay`
constructor are now required.
@crisbeto crisbeto force-pushed the overlay-v11-breaking-changes branch from d7a4e38 to 7f987c6 Compare September 23, 2020 09:04
@annieyw annieyw merged commit 4ef3d3f into angular:master Sep 23, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Sep 24, 2020
@crisbeto @wagnermaciel
refactor(cdk/overlay): remove deprecated APIs for v11 (angular#20511)
8ad91b2 
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that
these changes target primarily the breaking changes that should be easier to
land. I've left out removing `ConnectedPositionStrategy` which has a separate
PR (angular#17519), and `GlobalPositionStrategy.width` and
`GlobalPositionStrategy.height`, because they'll be trickier to land.

BREAKING CHANGES:
* The `OVERLAY_PROVIDERS` constant has been removed. Import
`OverlayModule` and use the providers directly instead.
* `_platform` parameter of the `OverlayContainer` constructor is now required.
* `_platform` parameter of the `FullscreenOverlayContainer` constructor is
now required.
* `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef`
constructor are now required.
* `_location` and `_outsideClickDispatcher` parameters of the `Overlay`
constructor are now required.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@crisbeto @jelbourn @mmalerba @googlebot @annieyw @andrewseguin