-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(youtube-player): YT.Player is not a constructor #20616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(youtube-player): YT.Player is not a constructor #20616
Conversation
fixes a race condition where window.YT would be truthy but window.YT.Player would not be ready. Fixes angular#20598
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be captured in a unit test? Otherwise we may end up regressing in the future.
added a test to prevent reggression, the test mimics a possible state of the YT object when loading, when window.YT exists but window.YT.Player does not. Fixes angular#20598
9ea1924
to
40024bd
Compare
I modified the 'it waits until the api is ready before initializing' test to account for this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(youtube-player): YT.Player is not a constructor fixes a race condition where window.YT would be truthy but window.YT.Player would not be ready. Fixes #20598 * fix(youtube-player): YT.Player is not a constructor test added a test to prevent reggression, the test mimics a possible state of the YT object when loading, when window.YT exists but window.YT.Player does not. Fixes #20598 (cherry picked from commit b0d0388)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes a race condition where window.YT would exist but window.YT.Player would not.
Fixes #20598