build: run edge tests on browserstack #20662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
karma-launchers-update
branch
2 times, most recently
from
940398a to
37ba1c0
Compare
crisbeto
force-pushed
the
karma-launchers-update
branch
9 times, most recently
from
55aa082 to
0f60f4c
Compare
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs.
crisbeto
force-pushed
the
karma-launchers-update
branch
from
0f60f4c to
78b6d8d
Compare
crisbeto
changed the title
crisbeto
requested review from
devversion,
mmalerba and
a team
as code owners
crisbeto
added
merge safe
P2
crisbeto
commented
Sep 27, 2020
| @@ -354,23 +354,23 @@ export function crossEnvironmentSpecs( | |||
| }); | |||
|
|
|||
| it('should be able to hover', async () => { | |||
| const host = await harness.host(); | |||
| let classAttr = await host.getAttribute('class'); | |||
| const box = await harness.hoverTest(); | |||
There was a problem hiding this comment.
I decided to change these tests to hover an element inside the host, instead of the host itself, because the first assertion, that ensures that the element doesn't start off as hovered, was breaking on Browserstack. What I think was going on is that it would put the cursor inside the viewport when the window is opened, throwing off our assertion since the host takes up most of the screen and the cursor would land on it.
mmalerba
pushed a commit
that referenced
this pull request
Sep 29, 2020
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs. (cherry picked from commit 8b6aab1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs.