-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: run edge tests on browserstack #20662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
940398a
to
37ba1c0
Compare
55aa082
to
0f60f4c
Compare
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs.
0f60f4c
to
78b6d8d
Compare
@@ -354,23 +354,23 @@ export function crossEnvironmentSpecs( | |||
}); | |||
|
|||
it('should be able to hover', async () => { | |||
const host = await harness.host(); | |||
let classAttr = await host.getAttribute('class'); | |||
const box = await harness.hoverTest(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to change these tests to hover an element inside the host, instead of the host itself, because the first assertion, that ensures that the element doesn't start off as hovered, was breaking on Browserstack. What I think was going on is that it would put the cursor inside the viewport when the window is opened, throwing off our assertion since the host takes up most of the screen and the cursor would land on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs. (cherry picked from commit 8b6aab1)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs.