Skip to content

docs(material/button): add button harness example #20722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

docs(material/button): add button harness example #20722

merged 1 commit into from
Oct 16, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Oct 5, 2020 •
edited
Loading

change generate-example-modules.ts to account for .spec files.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2020
@annieyw annieyw force-pushed the button-harness-example branch 2 times, most recently from ff5abd0 to 37d7471 Compare October 8, 2020 17:49
@annieyw annieyw marked this pull request as ready for review October 8, 2020 17:58
@annieyw annieyw requested review from andrewseguin and a team as code owners October 8, 2020 17:58
@annieyw annieyw requested review from jelbourn and mmalerba October 8, 2020 17:58
jelbourn
jelbourn approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor comments

@jelbourn jelbourn added docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 13, 2020
@annieyw annieyw force-pushed the button-harness-example branch from 37d7471 to 9df76c2 Compare October 14, 2020 16:56
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2020
@jelbourn jelbourn mentioned this pull request Oct 15, 2020
Closed
@annieyw annieyw merged commit 2d79ab7 into angular:master Oct 16, 2020
annieyw added a commit that referenced this pull request Oct 16, 2020
@annieyw
docs(material/button): add harness example (#20722)
d123a4d 
(cherry picked from commit 2d79ab7)
@annieyw annieyw deleted the button-harness-example branch November 9, 2020 19:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annieyw @jelbourn @googlebot