Skip to content

build: fix errors against latest @angular/bazel version #20779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

crisbeto
Copy link
Member

Fixes some errors that were introduced in the latest @angular/bazel version.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 13, 2020
@crisbeto crisbeto force-pushed the bazel-master-issue-test branch 6 times, most recently from ce57bbb to 980fb7d Compare October 14, 2020 21:18
Fixes some errors that were introduced in the latest `@angular/bazel` version.
@crisbeto crisbeto force-pushed the bazel-master-issue-test branch from 980fb7d to cc47863 Compare October 14, 2020 21:23
With Angular 11.0.0-next.6, trying to `rm` the symlink here without
unlinking it fails for ViewEngine.
@annieyw annieyw added the target: major This PR is targeted for the next major release label Oct 14, 2020
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2020
@annieyw annieyw marked this pull request as ready for review October 14, 2020 23:41
@annieyw annieyw merged commit 59d3840 into angular:master Oct 14, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants